Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: refine logs (#723) #727

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 28, 2021

cherry-pick #723 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/727

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/727:release-4.0-c206addacab1

What problem does this PR solve?

*: restore: more log for split region

It helps investigating #709.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jan 28, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jan 28, 2021

/lgtm

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jan 28, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jan 28, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@overvenus
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit f8b930f into pingcap:release-4.0 Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants